Pomax / node-flickrapi

A node.js (and client-library) implementation of the Flickr API with oauth API key authentication and API method proxying
177 stars 52 forks source link

overhaul the code to ES6, with as much code replaced by now-available packages. #100

Open Pomax opened 7 years ago

Pomax commented 7 years ago

Very specifically, the auth system now has plenty of npm libraries available, and the API fetch should be a "one time, and afterwards only if called with --update" thing.

Pomax commented 7 years ago
Pomax commented 7 years ago
Pomax commented 7 years ago
brentchow commented 7 years ago

Why is there a directory of Flickr methods being built?

Since the Flickr API is stable, it seems reasonable to just include the methods so that errors from building the directory can be avoided.

Thanks.

Pomax commented 7 years ago

That's what the comment you liked says should happen. The reason it syncs against the Flickr API itself is because no one, not me, not you, not even the Flickr API product manager, can guarantee that it's locked. Stable is not the same as "unchanging", as any non-backward-compat changes can be introduced at any time. It's also data that already has an authoritative location (the Flickr API itself) so committing it to a repo makes little sense, that's mostly just data duplication.

So the flow I want to see is that an install of this library comes with fetching the current API, once (since it's already accessing the internet in order to install this library - contacting Flickr during that process simply works in that context), and then because the API doesn't change too often, should only be resynced on request by the user who installed the library.

brentchow commented 7 years ago

fair. thanks, I appreciate the quick response.