search

Pomax / nrGrammar

The Nihongo Resources grammar book: "An Introduction to Japanese; Syntax, Grammar & Language"
334 stars 36 forks source link

Use code points from CJK Strokes block #33

Closed Szunti closed 6 years ago

Szunti commented 6 years ago

Except for ⺄, which is from CJK Radical Supplements. The biggest problem was with 𠃍 (from CJK Unified Ideographs Extension B) eg. adobe-source-han doesn't have a glyph for that.

Pomax commented 6 years ago

interesting, but can you explain what this fixes? The book generates with "not adobe-source-han at all", and the glyphs in the text looked quite fine using the fonts that are defined in the preamble.

Is this a web-only fix? If so, at the very least an @font-face rule will be necessary in the html that gets generated.

Szunti commented 6 years ago

Yes it is the web, http://pomax.github.io/nrGrammar/#section-1-3-Kanji has a missing glyph with only Source Han font installed. I have only that one, because it looks nice imo and this was the most popular choice when I searched the net for one.

Pomax commented 6 years ago

Then the solution here is not "fix the content" but "fix the font that is used online, for everyone". Asking people to install a font just for a website, even if it's a book, is a no-go, that should just be a @font-face rule in the CSS that loads a subset webfont containing only the glyphs necessary to render these CJK Radical Supplement + Extension B glyphs.

As such, I'm going to have to close this PR, but I've filed https://github.com/Pomax/nrGrammar/issues/34 so solve the underlying problem ("I don't have the right font so this looks wrong").