search

Pomax / react-onclickoutside

An onClickOutside wrapper for React components
MIT License
1.83k stars 187 forks source link

Added reaction on disableOnClickOutside property change #318

Closed todesstoss closed 1 year ago

todesstoss commented 5 years ago

Added reaction on disableOnClickOutside property change. Activates on false, deactivates on true. Currently this property affects activation only on component’s mount phase

Fix for https://github.com/Pomax/react-onclickoutside/issues/317

dbratz1177 commented 5 years ago

bump on this getting merged. i'm currently having to do a work around for the issue this addresses

Pomax commented 5 years ago

This will need a rebase, but mostly because v6.9.0 was released in the mean time, which introduced just enough code to require manual code selection.

todesstoss commented 5 years ago

Sorry for the delay. PR Updated

tomasztomys commented 4 years ago

please merge

bkingery commented 2 years ago

+1 on getting this merged.

tomasztomys commented 1 year ago

why closed?

Pomax commented 1 year ago

Because time moved on and React completely changed how things are "supposed to be done". Modern React is based on hooks, and https://github.com/Pomax/react-onclickoutside#functional-component-with-usestate-hook explains how to do what this HoC achieved for older versions of React.