Update react & react-dom peer-dep to support 17.x

Pomax / react-onclickoutside

An onClickOutside wrapper for React components

MIT License

1.83k stars 187 forks source link

Update react & react-dom peer-dep to support 17.x #347

Closed h3rmanj closed 3 years ago

h3rmanj commented 3 years ago

Addresses #346

Pomax commented 3 years ago

Unfortunately, this alone is not enough to make things work. The CI task is currently failing on uglify, but I'm sure there are more deps that need to be checked before this will pass.

h3rmanj commented 3 years ago

The master branch and the latest release 6.9.1 fails for the same reason, I'm guessing there is some old build pipeline here? I probably could look at it if you'd like though. This PR is only to fix the issue of not being able to install this package at all if you have npm v7, and react v17.

h3rmanj commented 3 years ago

The warnings flag is a top-level option to uglify, so I moved it out of the compress options. Seems to have fixed the pipeline. It's false by default though, but i left it there for good measure.

Pomax commented 3 years ago

cheers. I'll merge this in and push a minor update.

Pomax commented 3 years ago

v6.10.0 published