search

Pomax / react-onclickoutside

An onClickOutside wrapper for React components
MIT License
1.82k stars 187 forks source link

353 typescript bug. #354

Closed OscarBakker closed 3 years ago

Pomax commented 3 years ago

If this fixes a genuine issue I'll all for it, but you kind of need to at least write a short explanation of why you filed this PR?

OscarBakker commented 3 years ago

If this fixes a genuine issue I'll all for it, but you kind of need to at least write a short explanation of why you filed this PR?

True! I was using ViteJS for a typescript react project. When starting the project I instantly got an error. I think due to the on demand compilation which was going on with ViteJS, the file which included react-onclickoutside could'nt compile when I was actually starting the app in the browser.

OscarBakker commented 3 years ago

Is the problem clear?

Pomax commented 3 years ago

Yep. Does this pass npm test?

OscarBakker commented 3 years ago

Yep. Does this pass npm test?

yes it does.

OscarBakker commented 3 years ago

can you merge it?

Pomax commented 3 years ago

yep

Pomax commented 3 years ago

6.11 published