search

Pomax / react-onclickoutside

An onClickOutside wrapper for React components
MIT License
1.83k stars 187 forks source link

Dropping support for react 16 (and 15) #357

Closed ryanthemanuel closed 3 years ago

ryanthemanuel commented 3 years ago

I noticed in 6.11.0 that support was dropped for react 16 and 15:

https://github.com/Pomax/react-onclickoutside/commit/da310a7dabec5ee2efb7a763d282a590f8925e77

With this change, people that were depending on ^6.0.0 of react-onclickoutside and react 16 will pull in 6.11.0 and react 16 and be broken. From my understanding of major versions, that type of change typically necessitates a major version bump of the package that makes the change (in this case react-onclickoutside).

mgummelt commented 3 years ago

Agreed. This breaks several versions of react-datepicker, since it uses react-onclickoutside@"^6.8.0" as a dependency.

Pomax commented 3 years ago

if so, that certainly wasn't intentional, the only thing that commit was supposed to do was bump the rollup and webpack versions to the point where things can actually be bundled without crashing again, with karma actually running the tests without crashing, too.

I'll have a look at why those bumps turned off support for React 15 and 16, because they shouldn't have.

Pomax commented 3 years ago

Looks like the version bumps also messed with the react versions, turning the nice "^15.5.x || ^16.x || ^17.x" into the fairly useless "^17.x" so let's undo that immediately.

Pomax commented 3 years ago

I've rolled back the react base and peer dependencies to what they were before, and pushed out v6.11.2, let me know if that fixes things because as far as I know, it should have.

mjhenkes commented 3 years ago

@Pomax 6.11.2 has corrected this issue for me. Thank you for the quick turn around!

Pomax commented 3 years ago

glad to hear it.