search

PomeloFoundation / Pomelo.EntityFrameworkCore.MySql

Entity Framework Core provider for MySQL and MariaDB built on top of MySqlConnector
MIT License
2.69k stars 381 forks source link

Public Jetbrains.Annotation definitions collide with other code #113

Closed joepb closed 7 years ago

joepb commented 7 years ago

Steps to reproduce

Consume the module in a project that also includes the Jetbrains.Annotations nuget.

The issue

Because both Pomelo.EntityFrameworkCore.MySql and Jetbrains.Annotations expose the same public members, the compiler is unable to determine the correct one, resulting in errors.

Error CS0433
The type '...' exists in both 'JetBrains.Annotations.NetStandard, Version=10.2.1.0, Culture=neutral, PublicKeyToken=1010a0d8d6380325' and 'Pomelo.EntityFrameworkCore.MySql, Version=1.0.1.0, Culture=neutral, PublicKeyToken=null' SampleImporter..NETCoreApp,Version=v1.0

Further technical details

Marking the Resharper code hints as internal should fix all collisions. The analysis engine of Resharper supports this out of the box.

caleblloyd commented 7 years ago

Thanks for the contribution! Shipped in 1.0.2-prerelease-10002 and 1.1.0-preview1-10002