search

PomeloFoundation / Pomelo.JsonObject

JSON Object optimized for MySql 5.7+ and Entity Framework Core
MIT License
7 stars 7 forks source link

Namespace #10

Open Daniel15 opened 5 years ago

Daniel15 commented 5 years ago

Why is JsonObject in the System namespace? That's very confusing because it makes it seem like this is part of the .NET framework (rather than a third-party package), and there's also a JsonObject class in the System.Json namespace (https://docs.microsoft.com/en-us/dotnet/api/system.json.jsonobject?view=dotnet-plat-ext-2.1). Could you please consider moving it to a Pomelo.JsonObject namespace?

lauxjpn commented 4 years ago

@caleblloyd Is there any particular reason for putting JsonObject in the System namespace?

caleblloyd commented 4 years ago

Really just legacy reasons. Changing it would be a BC Break

NPGSQL has JSON support now and they use an interesting approach:

https://www.npgsql.org/efcore/mapping/json.html

Amongst other options, they use the .NET Core 3.0 System.Text.Json APIs

https://devblogs.microsoft.com/dotnet/try-the-new-system-text-json-apis/

Aligning seems like a logical course if we were to break BC anyways