search

PomepuyN / discreet-app-rate

A lightweight non intrusive app rate reminder for Android
http://nicolaspomepuy.fr/non-intrusive-app-rate
Apache License 2.0
464 stars 51 forks source link

Use more beautiful libraries to show the rate bar. #3

Closed tasomaniac closed 10 years ago

tasomaniac commented 10 years ago

The app rate bar is definitely not customizable. The height of it also fixed. It is actually better to keep it short but I think there should not be a restriction.

I think other libraries for showing alerts can be used in this library and it can be great actually. Crouton can be used. It has to be customized a lot I think. SuperToasts may be better for this.

I think it will be more discreet :)

I can do it if it is ok. I want to discuss it here before integrating it.

PomepuyN commented 10 years ago

You're right, I decided to focus on behavior for the 1.x.x version of the library. I also planned to make it more customizable in the future by allowing to add a view that would be rendered in an empty container. However, using another library as a dependency, is not the way I would follow. I think adding a Setting with the view should be enough.

tasomaniac commented 10 years ago

Why not use another library? Libraries can use libraries. Look ActionBar-PullToRefresh for example.

The 2 libraries I have written took too much time to be customizable. You have to implement all the code they have written in order to do that.

On Mon, Mar 17, 2014 at 10:10 AM, Nicolas POMEPUY notifications@github.comwrote:

You're right, I decided to focus on behavior for the 1.x.x version of the library. I also planned to make it more customizable in the future by allowing to add a view that would be rendered in an empty container. However, using another library as a dependency, is not the way I would follow. I think adding a Settinghttps://github.com/PomepuyN/discreet-app-rate/wiki/Settingswith the view should be enough.

Reply to this email directly or view it on GitHubhttps://github.com/PomepuyN/discreet-app-rate/issues/3#issuecomment-37792422 .

Said Tahsin Dane

Lead Mobile Developer, Metrekare.com

tasomaniac.com http://blog.tasomaniac.com/

metrekare.com http://www.metrekare.com/ | iPhone Apphttp://app.adjust.io/52edzz | Android App http://app.adjust.io/1tl52j

PomepuyN commented 10 years ago

My concern is about importing third part bugs and feature requests into this lib. I also think that proposing a view to add should not be that long. But if you have a better idea I will be happy to review it.

tasomaniac commented 10 years ago

Adding custom view is relatively simple. If you just add that feature these libraries are not needed I think. On Mar 17, 2014 1:18 PM, "Nicolas POMEPUY" notifications@github.com wrote:

My concern is about importing third part bugs and feature requests into this lib. I also think that proposing a view to add should not be that long. But if you have a better idea I will happy to review it.

Reply to this email directly or view it on GitHubhttps://github.com/PomepuyN/discreet-app-rate/issues/3#issuecomment-37805187 .

aluxian commented 10 years ago

@PomepuyN Awesome library, I look forward to using it, but I need to be able to customise the entire view, not just a view contained in your own, pre-styled one. What do you think?

PomepuyN commented 10 years ago

I think it shouldn't be a problem. "My view" is a RelativeLayout filling the whole window.

aluxian commented 10 years ago

Great! I don't mean to put pressure on you, but when can I expect this to be implemented?

PomepuyN commented 10 years ago

As the behavior seems to be working fine, I will be able to work on the view now. Unfortunately, I have no ETA to give for now, but I think it should come really soon.

PomepuyN commented 10 years ago

I just pushed the first implementation of this feature in the Development branch. Please keep keep in mind that it's a WIP. I already updated the sample so you can use it as an example.

aluxian commented 10 years ago

Cool, I'm checking it out right now.

One more tip about making the view more beautiful, you should add a pressed state to the X button to make it feel more responsive.

LE: The implementation looks good to me.

PomepuyN commented 10 years ago

Glad to read it. I will be probably promoted later today. By the way, I pushed the button background to the dev branch.

PomepuyN commented 10 years ago

The new version has been promoted and merged into master branch. It includes support for custom view.