PomepuyN / discreet-app-rate

A lightweight non intrusive app rate reminder for Android
http://nicolaspomepuy.fr/non-intrusive-app-rate
Apache License 2.0
464 stars 51 forks source link

problem on android L #31

Open ligi opened 10 years ago

ligi commented 10 years ago

just playing around with L and stumbled uppon this:

discreteapprate_problem

a fitsSystemWindows on the right place might help

easycheese commented 9 years ago

I submitted a pull request that takes care of it for my app if you use the

getWindow().getDecorView().setSystemUiVisibility( View.SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION);

Method of adding translucency. I couldn't seem to get anything to work using android:fitsSystemWindows.

ligi commented 9 years ago

great! at the moment I use android:fitsSystemWindows - do you have an example of the other method? My initial attempts where not producing the result I wanted

easycheese commented 9 years ago

Check out the merge request from issue 31: Here is the code commit:

int translucentLolliPop = activity.getWindow().getDecorView().getSystemUiVisibility(); boolean isTranslucentLolliPop = (translucentLolliPop== View.SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION);

if (isTranslucent || isTranslucentLolliPop) {

... }