Pong420 / google-tasks-desktop

Unofficial Google Tasks Desktop Client
MIT License
138 stars 16 forks source link

wrong icon name on DEB #67

Closed varlesh closed 3 years ago

varlesh commented 3 years ago
[Desktop Entry]
Name=Google Tasks
Exec="/opt/Google Tasks/google-tasks-desktop" %U
Terminal=false
Type=Application
Icon=./public/icon/icon.png
StartupWMClass=google-tasks-desktop
Encoding=UTF-8
Comment=Unofficial google tasks desktop application
Categories=Utility;

icon installed on hicolor theme directory need change to: Icon=google-tasks-desktop

https://github.com/Pong420/google-tasks-desktop/blob/master/package.json#L93

Pong420 commented 3 years ago

Thanks, are you confirm this change fixes the issue? If not, could you try the new release of 3.1.2-deb works fine? Or clone the repo and pack it yourself

varlesh commented 3 years ago

Yes, thx :+1:

varlesh commented 3 years ago

This line needed? https://github.com/Pong420/google-tasks-desktop/blob/master/package.json#L87

varlesh commented 3 years ago

maybe it's broken appimage too...

varlesh commented 3 years ago

I think it's related with #66 issue:

./Google.Tasks-3.1.2_d480d7caef5a55da2e06acc473bb41c1.AppImage
qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 615, resource id: 16066855, major code: 40 (TranslateCoords), minor code: 0
ERROR: appimage_register_in_system : Icon field contains path
qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 779, resource id: 16066939, major code: 40 (TranslateCoords), minor code: 0
Pong420 commented 3 years ago

I check out the documentation again, my value is incorrect. I have uploaded a fixed version. Could you test for it?

https://github.com/Pong420/google-tasks-desktop/releases/tag/3.1.3

varlesh commented 3 years ago

All fine, you can close #66

Pong420 commented 3 years ago

thanks !