search

Pong50887 / RentHub-Connect

3 stars 0 forks source link

Iteration5 #112

Closed PHIMNADA024 closed 2 weeks ago

PHIMNADA024 commented 2 weeks ago

Already Finish Iteartion 5

Pong50887 commented 2 weeks ago

Goodjob, some problem with PEP8 but we can solve it next iteration.

NewOsakA commented 2 weeks ago

Great work, team! Let's make the next iteration even better by adhering to PEP8 guidelines.

codecov-commenter commented 2 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 84.51243% with 81 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
renthub/admin/rental_payment_admin.py 33.33% 22 Missing :warning:
...est_booking/test_payment_view/test_payment_post.py 29.41% 12 Missing :warning:
renthub/views/dashboard_view.py 42.85% 12 Missing :warning:
renthub/views/room_payment_view.py 77.55% 11 Missing :warning:
.../tests/test_announcement/test_announcement_view.py 73.07% 7 Missing :warning:
renthub/views/room_overview_view.py 50.00% 7 Missing :warning:
...enthub/tests/test_booking/test_room_detail_view.py 85.71% 5 Missing :warning:
renthub/models/rental_payment.py 81.25% 3 Missing :warning:
renthub/admin/rental_admin.py 50.00% 1 Missing :warning:
renthub/tests/test_booking/test_payment_status.py 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
mysite/settings.py 97.22% <ø> (-2.78%) :arrow_down:
renthub/admin/__init__.py 100.00% <100.00%> (ø)
renthub/admin/announcement_admin.py 100.00% <ø> (ø)
renthub/admin/room_admin.py 100.00% <100.00%> (ø)
...lter_notification_options_alter_rental_end_date.py 100.00% <100.00%> (ø)
...lter_announcement_content_alter_rental_end_date.py 100.00% <100.00%> (ø)
...ntal_is_paid_rental_last_checked_month_and_more.py 100.00% <100.00%> (ø)
...lter_rental_end_date_alter_roomtype_description.py 100.00% <100.00%> (ø)
renthub/models/__init__.py 100.00% <100.00%> (ø)
renthub/models/announcement.py 100.00% <100.00%> (ø)
... and 43 more

... and 3 files with indirect coverage changes

Karczel commented 2 weeks ago

We have achieved a lot. But I never expected testing would be the hardest part of software development.