Ponharish / pe

0 stars 0 forks source link

Ambiguity in the of usage Assign Command #7

Open Ponharish opened 1 week ago

Ponharish commented 1 week ago

The assigncommand seems to perform two different tasks depending on the parameter given. When role is specified, it updates the role of a person whereas when w is mentioned, it seems to assign them to a wedding.

Since the role is something attached to a person, shouldn't it be changed using the edit command?

My rationale: If John is a person saved in the application, John could have only one role. So the role is something that is attached to John. It is different from the case when 'John is assigned to be a DJ for one particular wedding'. Hence making changes to the role using assign may not be appropriate.

nus-se-script commented 1 week ago

Team's Response

If the assign command is confusing because it can be used to assign a role to a person, or a person to a wedding. The adding or editing of a role can be changed to be a feature of the edit command, and assign command can be reserved solely for assigning a person to a wedding. This improvement can be made easily at the next iteration of the project.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]