TIMELINE. Description popup does not popup in the correct location

When I click on the event, the popup dialog it appears at the top of the
browser window. Please see this screen shot
(http://www.lucasnodine.com/Untitled-1.jpg). This page does make extensive
use of css, javascript and tables. Please let me know if anyone has any
suggestions or questions.

IE 7, untested in other browsers at this time 

[Submitted by Lucas Nodine on simile.mit.edu] 

http://simile.mit.edu/issues/browse/EXHIBIT-9 is a more detailed and
technical description of this same issue (though without the screenshot).
It probably shouldn't have been filed on Exhibit, though I had not verified
it present in stand-alone Timeline.
[ Show » ]
Johan Sundström - 08/Feb/07 10:56 PM
http://simile.mit.edu/issues/browse/EXHIBIT-9 is a more detailed and
technical description of this same issue (though without the screenshot).
It probably shouldn't have been filed on Exhibit, though I had not verified
it present in stand-alone Timeline.

[ Permlink | « Hide ]
Lucas Nodine - 09/Feb/07 12:09 AM
Update: Thanks to Johan I had a place to start exploring! I found that in
util/graphics.js about line 70 (I say about because I have modded and am
not sure I have the exact same code anymore) docHeight == 0. This, of
course, causes havoc for the rest of the code. I subbed in a function I
already was using to determine window height and it works again; however, I
do not believe it works as intended. But it still works!

Anyway, for anyone having this problem below is the function
getWindowHeight, simply include that on your page in whatever method you
want. and then on or around line 70 of util/graphics.js set docHeight =
getWindowHeight();

I cannot guarantee this will work for you, all I know is that it did for me
and im just prototyping right now anyway. So all suggestions and code
supplied here are as is without any warranty express or implied. Good luck :)

function getWindowHeight() {
    if( typeof( window.innerWidth ) == 'number' ) {
        //Non-IE
        return window.innerHeight;
    } else if( document.documentElement && (
document.documentElement.clientWidth ||
document.documentElement.clientHeight ) ) {
        //IE 6+ in 'standards compliant mode'
        return document.documentElement.clientHeight;
    } else if( document.body && ( document.body.clientWidth ||
document.body.clientHeight ) ) {
        //IE 4 compatible
        return document.body.clientHeight;
    }
}
[ Show » ]
Lucas Nodine - 09/Feb/07 12:09 AM Update: Thanks to Johan I had a place to
start exploring! I found that in util/graphics.js about line 70 (I say
about because I have modded and am not sure I have the exact same code
anymore) docHeight == 0. This, of course, causes havoc for the rest of the
code. I subbed in a function I already was using to determine window height
and it works again; however, I do not believe it works as intended. But it
still works! Anyway, for anyone having this problem below is the function
getWindowHeight, simply include that on your page in whatever method you
want. and then on or around line 70 of util/graphics.js set docHeight =
getWindowHeight(); I cannot guarantee this will work for you, all I know is
that it did for me and im just prototyping right now anyway. So all
suggestions and code supplied here are as is without any warranty express
or implied. Good luck :) function getWindowHeight() {     if( typeof(
window.innerWidth ) == 'number' ) {         //Non-IE         return
window.innerHeight;     } else if( document.documentElement && (
document.documentElement.clientWidth ||
document.documentElement.clientHeight ) ) {         //IE 6+ in 'standards
compliant mode'         return document.documentElement.clientHeight;     }
else if( document.body && ( document.body.clientWidth ||
document.body.clientHeight ) ) {         //IE 4 compatible         return
document.body.clientHeight;     } }

[ Permlink | « Hide ]
Johan Sundström - 09/Feb/07 01:47 AM
Thanks. A similar patch has been applied to the trunk of the subversion
tree. Chances are also your code might not be asking for popup bubbles of
integer sizes, but rather passing strings ("200" instead of 200, for
instance), which would lead to this same error. The bubble creator should
now cater broken input like that too, but it might be the issue you ran in
to, and be easy to fix. To convert a variable FOO from string to integer,
use parseInt( FOO, 10 );
[ Show » ]
Johan Sundström - 09/Feb/07 01:47 AM Thanks. A similar patch has been
applied to the trunk of the subversion tree. Chances are also your code
might not be asking for popup bubbles of integer sizes, but rather passing
strings ("200" instead of 200, for instance), which would lead to this same
error. The bubble creator should now cater broken input like that too, but
it might be the issue you ran in to, and be easy to fix. To convert a
variable FOO from string to integer, use parseInt( FOO, 10 );

[ Permlink | « Hide ]
Lucas Nodine - 09/Feb/07 10:35 AM
In util/graphics.js line 70: "var docHeight = doc.body.offsetHeight;" <--
this is where docHeight was getting set to 0. I have not spent the hours to
review the code to understand everything, but is there anywhere else you
would like me to check to see if I can provide you with additional, more
helpful information?
[ Show » ]
Lucas Nodine - 09/Feb/07 10:35 AM In util/graphics.js line 70: "var
docHeight = doc.body.offsetHeight;" <-- this is where docHeight was getting
set to 0. I have not spent the hours to review the code to understand
everything, but is there anywhere else you would like me to check to see if
I can provide you with additional, more helpful information?

[ Permlink | « Hide ]
Lucas Nodine - 09/Feb/07 01:07 PM
Apparently bundle did not get correctly built. I downloaded the new working
version and the non-bundled version works; however, bundle does not. Easy
fix, true, but just thought I would drop a notice to you.
[ Show » ]
Lucas Nodine - 09/Feb/07 01:07 PM Apparently bundle did not get correctly
built. I downloaded the new working version and the non-bundled version
works; however, bundle does not. Easy fix, true, but just thought I would
drop a notice to you.

[ Permlink | « Hide ]
Johan Sundström - 09/Feb/07 02:49 PM
Ah, sorry I forgot to note that I did not update the bundle. I'm leaving
final commits and pushing out the fixes to David (who might want to peer
review my fixes before pushing it live to people all over the world). I
avoided the bundling myself, even though that might be splitting the
push-out process into another unnecessary step, as it is a step that has
produced additional error sources earlier when run on my machine.

Good that the fixes worked for you, though! Probably lets them migrate to
the static build sooner.
[ Show » ]
Johan Sundström - 09/Feb/07 02:49 PM Ah, sorry I forgot to note that I did
not update the bundle. I'm leaving final commits and pushing out the fixes
to David (who might want to peer review my fixes before pushing it live to
people all over the world). I avoided the bundling myself, even though that
might be splitting the push-out process into another unnecessary step, as
it is a step that has produced additional error sources earlier when run on
my machine. Good that the fixes worked for you, though! Probably lets them
migrate to the static build sooner.
Original issue reported on code.google.com by GabrielR...@googlemail.com on 5 Apr 2009 at 3:02
PonteIneptique / simile-widgets

TIMELINE. Description popup does not popup in the correct location #158
