search

PontusO / mlight-4_2_pmd

4/2 channel LED light controller
1 stars 0 forks source link

locked out from device (Stack overflow) #19

Closed AndreasKSweden closed 12 years ago

AndreasKSweden commented 12 years ago

page: event map

Description: I checked several checkboxes and pressed modify. I made my change and pressed save.

The first time: I was locket out from the mlight. I was asked to enter admin and password but I could not log on. After reboot I was able to access the mlight again.

The second time: This time the mlight was not accessable at all. I didn't even answer ping.

PontusO commented 12 years ago

Coolt =)

PontusO commented 12 years ago

These errors were due to stack overrun in the device. The stack is slightly less than 128 bytes in depth and getting all our functionality in place is a bit tricky with only that amount of stack. I reduced the stack usage in the cgi function that caused the unit to crash. I will look into in-lining the code a little more in that module.

With this fix the unit should be much more stable than before.

AndreasKSweden commented 12 years ago

fick en ny "lockout" ska se om jag kan återskapa den i morgon.

Men på det stora hela gjorde jag så här:

Skapade 3 ramp actions (kanal 1-3) med 100 intensitet, ramp rate 1800 och step 1. Gick till time events och satte en ny tid. Sen gick jag till Time settings för att kolla klockan. Jag tror att rampningen hade börjat när jag fick min "lockout"

PontusO commented 12 years ago

Did some more optimizations to http-cgi.c as this is by far the worst stack consumer in the system. Try it out, and if something fails again, note what happened and reopen this issue again.