search

PonyGE / PonyGE2

PonyGE2: grammatical evolution and variants in Python
GNU General Public License v3.0
155 stars 92 forks source link

PonyGE2 should be compliant with pep8 #119

Closed nbro closed 2 years ago

nbro commented 3 years ago

After having dived a little into the source, I immediately found classes with identifiers like this my_class. Why? In Python, classes should use CamelCase. Any particular reason why my_class was used, or were you just careless?

dvpfagan commented 3 years ago

Yeah, hold our hands up there, certainly a little lax with the code review in places it would appear.

Again we were using pep-8 checkers in our IDE's during the initial dev of the project but over time it does appear that some issues have crept in.

Another thing to add to the list for future releases

Dave

On Wed, 30 Dec 2020 at 17:22, nbro notifications@github.com wrote:

After having dived a little into the source, I immediately found classes with identifiers like this my_class. Why? In Python, classes should use CamelCase. Any particular reason why my_class was used, or were you just careless?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PonyGE/PonyGE2/issues/119, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHTHOU46OP6ACC7CBTPAPDSXNOTZANCNFSM4VORCWXQ .

nbro commented 3 years ago

@dvpfagan This pull request https://github.com/PonyGE/PonyGE2/pull/121 fixes some of the issues. Please, take a look at it and let me know what needs to be changed for it to be accepted.

jmmcd commented 2 years ago

The PR above has been merged, but in general we should continue to be careful with PEP8.