search

Ponytech / appstoreconnectapi

Python wrapper around Apple App Store Api
https://ponytech.net/projects/app-store-connect
MIT License
160 stars 74 forks source link

Avoid pinned dependencies #35

Closed josepanguera closed 3 years ago

josepanguera commented 3 years ago

On 8de43ea the dependencies were pinned in setup.py. The problem with that is that now is now longer possible to install this library and, for instance, the latest release of requests alongside.

Since I believe this project has the vocation of being a library and not a standalone project I suggest to instead of pinning the dependencies just force minimum versions*.

I'd be very happy to do a PR if you agree with it.

*I know that jwt 2.* is problematic. For that particular dependency we could just set a minimum and a maximum version.

ppawlak commented 3 years ago

Hi @josepanguera, thanks for reporting this issue.

By "installing this library" do you mean system wide? I have never had this issue as I always use virtualenvs. What is your use case? But anyway I don't see any reasons for setting only a minimum version dependency on requests. Please submit a PR

josepanguera commented 3 years ago

No, I meant inside a virtualenv but within a project that does uses other libraries. I explain myself badly :)

Anyway, I created the pr on #36.

ppawlak commented 3 years ago

No, I meant inside a virtualenv but within a project that does uses other libraries.

OK make sense! I'll merge the PR, I just let a comment about the cryptography package.

ppawlak commented 3 years ago

PR merged, thank you @josepanguera

louisguitton commented 3 years ago

hi @ppawlak could you cut a release on pypi with this change please 🙏

ppawlak commented 3 years ago

hi @ppawlak could you cut a release on pypi with this change please 🙏

Wow, I didn't realized it was not released yet. I'll do it shortly.

ppawlak commented 3 years ago

@louisguitton Version 0.9.1 including this fix is available : https://pypi.org/project/appstoreconnect/0.9.1/

Can you confirm this fixes dependencies on your project?

louisguitton commented 3 years ago

it does :) thank you @ppawlak for the quick response !