search

Ponytech / appstoreconnectapi

Python wrapper around Apple App Store Api
https://ponytech.net/projects/app-store-connect
MIT License
161 stars 74 forks source link

Accept pull requests? #6

Closed EricG-Personal closed 5 years ago

EricG-Personal commented 5 years ago

I needed to get a list of devices associated with an account and your project provided a very nice base for doing that. I forked the project and added the support.

https://github.com/EricG-Personal/appstoreconnectapi/commit/12ae8f389e4ff787b9e8d8ff0be0fa9268362eba

I think I got everything correct (or at least it worked for me). If you would like me to do a pull request, I can and you have one more API implemented.

ppawlak commented 5 years ago

Sure! Please do!

I just left a comment in your code.

EricG-Personal commented 5 years ago

Thanks for the suggestion. I will make the update to the code.

As for the content_type thing, based on what I’ve read, they all probably should be using application/vnd.api+json ... at least according to jsonapi.org

It is all just json.

On Thu, Sep 19, 2019 at 2:23 AM ppawlak notifications@github.com wrote:

Sure! Please do!

I just left a comment in your code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Ponytech/appstoreconnectapi/issues/6?email_source=notifications&email_token=AAHDM46F4BRAWK6J6ZWOBWTQKMLFJA5CNFSM4IYFCXK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7CLM4A#issuecomment-532985456, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHDM4ZMCVIQW7YVFCXZ2S3QKMLFJANCNFSM4IYFCXKQ .