search

Poodmund / Outer-Planets-Mod

Outer Planets Mod for Kerbal Space Program
https://forum.kerbalspaceprogram.com/index.php?/topic/184789-1
Other
34 stars 15 forks source link

Gravity scan gives incorrect flavor text #11

Closed dmarcuse closed 6 years ago

dmarcuse commented 6 years ago

Around Sarnus (and maybe the other planets), the gravity scan gives incorrect flavor text. I think it has to do with how the gravity scan uses biomes in low orbit, unlike the other sensors.

Gravity scan using goo flavor text

Gravity scan using thermometer flavor text

Poodmund commented 6 years ago

I can confirm this issue. The science definitions in the Localization file are not tied to the any experiment class and therefore any experiment in a region/zone could display a message from any experiment type.

EDIT: I'll fix it this evening.

Poodmund commented 6 years ago

This is a bigger issue than I thought it was; it is going to take me quite a bit longer as the localization and science defs files are quite borked. I'll get to it.

dmarcuse commented 6 years ago

Glad to hear the mod is still being updated - it's not a critical issue, so I wouldn't worry about how long it takes

Poodmund commented 6 years ago

@apemanzilla would you be able to download and test the files changed in the latest commit?

https://github.com/Galileo88/OPM_Galileo/commit/50adb9d6be2e3a71bbafbe5288623835338f9308

These should fix all the science definition issues.

dmarcuse commented 6 years ago

I haven't played KSP in a few months, but I'll take a look if I have spare time.

Poodmund commented 6 years ago

I think this is all now resolved with commit: https://github.com/Galileo88/OPM_Galileo/commit/fd60fb115bacba678973563fced66113571ad560