Pool-Of-Tears / GreenStash

Simple FOSS android app to help you plan and manage your savings goals easily and establish the habit of saving money.
https://pooloftears.in
MIT License
583 stars 48 forks source link

[Feature Request] Remove fractions from some currencies #63

Closed Cloudef closed 8 months ago

Cloudef commented 8 months ago

Checklist

Is your feature request related to a problem? Please describe.

Hello, great app first of all! I'd love to have fractions removed from some currencies like JPY.

As seen in the screenshot below, the extra ,00 is unneeded noise for JPY. It also makes the "Currently saved ¥,00" look awkard. Screenshot_20240111-112425_GreenStash

Describe the solution you'd like

Remove fractions and show ¥,00 as ¥0

How will you/everyone benefit from this feature?

I think the people using the currencies with 0 decimals as listed in this article would benefit https://docs.adyen.com/development-resources/currency-codes/

Additional context

No response

starry-shivam commented 8 months ago

I see, thanks for linking me list of currencies who use zero decimal, I'll try to fix this in upcoming releases.

Cloudef commented 8 months ago

It seems kotlin and java has tools for handling localized currencies already: https://developer.android.com/reference/kotlin/android/icu/util/Currency https://stackoverflow.com/questions/13181143/how-can-i-feed-a-iso4217-currency-code-to-a-numberformat These might help you as well

starry-shivam commented 8 months ago

Thats great! thanks again for looking into and finding them out :)