Add PiP button to video tab bar in newer versions

PoomSmart / YouPiP

Enable native PiP in iOS YouTube app.

MIT License

96 stars 33 forks source link

Add PiP button to video tab bar in newer versions #88

Closed NguyenASang closed 9 months ago

NguyenASang commented 11 months ago

This pull request is a hacky way to add PiP button to video tab bar in newer YouTube versions (resolved #43). If this pull request gets merged, I think we should also remove the fake version code.

Note: Need to be tested in versions above 17.39.4 (I can't)

NguyenASang commented 11 months ago

Convert to draft since I think I should simplify it.

NguyenASang commented 11 months ago

@PoomSmart Can you test it in newer versions, so we can fix the remaining bugs.

PoomSmart commented 11 months ago

Can do, if I have time.

PoomSmart commented 9 months ago

Is this ready? I saw additional commits. @NguyenASang

NguyenASang commented 9 months ago

@PoomSmart It actually ready now.

PoomSmart commented 9 months ago

@NguyenASang It mostly works, besides the font.

iOS 15.4.1, font fallback to Times New Roman.

IMG_9A0556DE8C1B-1

PoomSmart commented 9 months ago

This works, though: [UIFont boldSystemFontOfSize:12].

NguyenASang commented 9 months ago

@PoomSmart Yea, it works on mine also.

NguyenASang commented 9 months ago

@PoomSmart The colors are weird in older versions, I will open another pull request to fix it soon.