PoonLab / Kaphi

Kernel-embedded ABC-SMC for phylodynamic inference
GNU Affero General Public License v3.0
4 stars 2 forks source link

Robinson-Foulds distance calculations not consistent with Kuhner-Yamato #117

Closed ArtPoon closed 6 years ago

ArtPoon commented 6 years ago

See issue #85

ArtPoon commented 6 years ago

In brief, our implementation (and others) are consistently giving half the distance of the Kuhner-Yamato implementation.

ArtPoon commented 6 years ago

Making this low priority, let's not expend too much resources into diagnosing someone else's implementation of RF distance

gtng92 commented 6 years ago

We did not actually implement RF.dist, KF.dist, and path.dist metrics. We used the package phangorn for this. Phangorn requires the igraph library to be re-compiled when bringing in this package (even though Kaphi itself has already compiled igraph). Would it be better simply to re-implement these distances again ourselves?

ArtPoon commented 6 years ago

For now use phangorn. Let's see how useful these distances will be before we think about re-implementing anything.