PoonLab / Kaphi

Kernel-embedded ABC-SMC for phylodynamic inference
GNU Affero General Public License v3.0
4 stars 2 forks source link

Hard code in max number of iterations for SMC run? #124

Closed gtng92 closed 6 years ago

gtng92 commented 6 years ago

Two runs "completed" in issue #123 had to be manually stopped. example-compartmental.beta.gamma.mu.pdf example-compartmental.RF.dist.iter361.pdf

After saving the TSV files and creating the PDFs of the results before stopping the run, it was clear that the runs had the potential to run infinitely. Some of the parameter estimates would flatline at a value for over 100 iterations, or vary within a param value range of 0.5.

ArtPoon commented 6 years ago

Need to decide what is diagnostic of a run that is stuck in an infinite cycle. Is it no change in epsilon after N steps?

ArtPoon commented 6 years ago

Use last 10 runs with acceptance rate of 0 as a stopping criterion (failure), notify user that the prior distributions may be misconfigured.

ArtPoon commented 6 years ago

smc.config contains an acceptance rate threshold but it doesn't seem to be implemented correctly because these runs should have been stopped.

gtng92 commented 6 years ago

Re-running simulation that produced the PDF using the RF.dist and recording the epsilons and acceptance rates in a separate file. Acceptance rates are fine, but epsilon is freezing at a value.

ArtPoon commented 6 years ago

I examined these logs with @gtng92 and it looks like all perturbed particles (from proposal distributions) are rejected over a stretch of iterations, which results in no change in epsilon. Need to investigate a couple of things:

Proposed actions: