Open genostack opened 1 year ago
Sorry, that text is misleading. It was meant to describe RDP itself, and not our open source re-implementation of RDP, which is unfortunately incomplete. I will amend.
Amended README file. I will leave this issue open as a placeholder for further work, for now. I don't think it should be that difficult to implement...
@SandeepThokala - I think this can be done with the following changes:
@SandeepThokala to create a PR into dev
Close issue upon merging PR #66
Need to check that if user specifies a reference set of sequences, the Triplet containing two parent sequences from this ref set should only be checked for the third sequence (coming from the main input alignment) as the potential child of two reference sequences. In other words, we should not be doing three times the work, checking whether either of the two reference sequences is a child recombinant.
Scanning only triplets that contain two reference sequences and one query sequence is sensible but if the reference set contains only one parent - in such situations the recombination signal might still be detectable but only if you consider the references as possible recombinants. Does that make sense?
On Mon, Jun 10, 2024 at 9:26 PM Art Poon @.***> wrote:
Need to check that if user specifies a reference set of sequences, the Triplet containing two parent sequences from this ref set should only be checked for the third sequence (coming from the main input alignment) as the potential child of two reference sequences. In other words, we should not be doing three times the work, checking whether either of the two reference sequences is a child recombinant.
— Reply to this email directly, view it on GitHub https://github.com/PoonLab/OpenRDP/issues/64#issuecomment-2159129962, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADEJ3TWGNPAPLXYAR3FOY7TZGX4UXAVCNFSM6AAAAABJC5E4W2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJZGEZDSOJWGI . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Thanks for this nice tool. In the documents ,it says "or to detect recombination breakpoints in a query sequence by comparing it against a reference set." , but how to use it in thid mode?