PoonLab / covizu

Rapid analysis and visualization of coronavirus genome variation
https://filogeneti.ca/CoVizu/
MIT License
46 stars 20 forks source link

Not all lineages being displayed in the tree #428

Closed bonnielu closed 2 years ago

bonnielu commented 2 years ago

Not all of the lineages are being displayed when we're using this set of test data. However, checking out a previous instance of the branch (prior to tree filtering) does yield the correct tree.

I'm thinking that this is potentially an edge case that we haven't covered? I've looked into it briefly and the redraw_tree function does produce a filtered df with the correct number of tips/nodes. So it likely has something to do with the actual drawing process.

Screen Shot 2022-09-30 at 6 27 22 PM (1) image (2)

bonnielu commented 2 years ago

This seems to occur when the initial display only has one lineage, resulting in disruptions to the x-scale calculations. I've created a fix which ensures that the drawtree process always uses the original df to calculated the x scale—will push it to dev in a bit!

ArtPoon commented 2 years ago

Fix in dev branch