Removed whitespace from date_string

PoonLab / covizu

Rapid analysis and visualization of coronavirus genome variation

https://filogeneti.ca/CoVizu/

MIT License

45 stars 20 forks source link

Removed whitespace from date_string #466

Closed nav-mohan closed 1 year ago

nav-mohan commented 1 year ago

On Safari we witnessed a bug with the date object being interpreted as invalid. This was because of the whitespace i.e new Date(date_string + ' '). All the beads would default to date = 0. Removing this whitespace fixed the bug. Must check whether removing this whitespace raises an issue in Chrome.

GopiGugan commented 1 year ago

https://github.com/PoonLab/covizu/commit/524a7a065b898d5df0912821635ff1dc0d353c01 https://github.com/PoonLab/covizu/commit/8dd9da7fa94ab3c7fc333ada090760f7a9608719

nav-mohan commented 1 year ago

For the time-being and for consistency across all branches, we will use the utcDate function from the dev/master branch to handle this issue. Once we've decided on the utility of that function we will implement changes consistently across all branches. Closing this PR for maintaining consistency between all branches.