Pop2121 / quake2-gwt-port

Automatically exported from code.google.com/p/quake2-gwt-port
GNU General Public License v2.0
0 stars 0 forks source link

Firefox shader validation requires mandatory precision specifier #31

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Compile & Run it in Firefox

What is the expected output? What do you see instead?
As of a recent Firefox build (probably 20082010 nightly) fragment shaders 
validation is always enabled which causes an error for the one used in this 
project.
Previously you could get away without entering the mandatory precision 
specifier in the fragment shaders but not anymore :)
Attached is a pretty straight forward patch, just adding a guard if GL_ES is 
defined (for older browsers not supporting this) and adding the specifier.

Works on the latest Firefox nightly and a month old Chrome nightly.
Running it with the latest chrome nightly still gives the error I mentioned in 
Issue 30, if I have time I'll try to find a regression range for Chrome and 
file a bug.

Original issue reported on code.google.com by smoo...@gmail.com on 22 Aug 2010 at 5:09

Attachments:

GoogleCodeExporter commented 8 years ago
I think this was fixed with the patch for issue #30.
Thanks for the diff!

Original comment by stefan.haustein on 25 Aug 2010 at 12:50

GoogleCodeExporter commented 8 years ago
Seem to be fixed by the other stuff you pushed together with the patch for 
issue #30.

Anyway, if this issue is fixed in current chromium with shader validation 
enabled, then it's fixed.

Original comment by jacob.be...@gmail.com on 25 Aug 2010 at 1:46

GoogleCodeExporter commented 8 years ago
Yeah- this was one of the issues Issue 32's patch fixed, working fine for me 
with the latest Firefox nightly...

Thanks Stefan

Original comment by smoo...@gmail.com on 25 Aug 2010 at 2:50

GoogleCodeExporter commented 8 years ago
Marking as verified, thanks again for the patches! :)

Original comment by stefan.haustein on 25 Aug 2010 at 3:14