search

PopMedNet-Team / popmednet

This is the repository for the open source code of the distributed data network platform PopMedNet
https://www.popmednet.org/
Other
11 stars 8 forks source link

Clarifications/updates in installation instructions (Required Software) #36

Closed lrasmus closed 2 years ago

lrasmus commented 2 years ago

As part of https://github.com/openjournals/joss-reviews/issues/4062, I am reviewing the installation instructions and had a few questions/requests for clarifications in the Required Software section:

  1. "Visual Studio Professional 2019" - is Professional required? Or will Community work (I am using Community, will report back if any hard stops, but seems to be working so far)
  2. ".NET Framework 4.7.2 Dev Pack" - I received a warning when loading Lpp.Adapters.sln that it is targeting v4.8. Should this reference 4.8 instead of 4.7.2? When I install 4.8 I don't get warnings.
  3. "MVC4 from https://www.microsoft.com/en-us/download/details.aspx?id=30683." - the paper says it uses MVC5, not 4
ddeehere commented 2 years ago

Visual Studio Community is sufficient. It is not necessary to use the Professional edition. We are now targeting .NET 4.8. 4.7.2 is no longer supported. We are now using MVC5, though MVC4 should still work. I will make these corrections in the documentation.

ddeehere commented 2 years ago

@lrasmus Documentation updated. MVC5 is integrated into the solution and does not have to be downloaded separately anymore.