Popalay / Tutors

A simple way to show the user interface tutorials
Apache License 2.0
82 stars 19 forks source link

Application State not properly handled causing tutorials not to respond or application crash when onResume #1

Closed larrytech7 closed 7 years ago

larrytech7 commented 7 years ago

Tutorials will not be able to complete (no longer respond to onCompleteAll events) or application may crash when the app resumes from some other activity to the activity showing the tutorials.

larrytech7 commented 7 years ago

Tested on Android 5.0, API level 21, Samsung Note 3, Issue seems not to persist on 5.1 above.

Popalay commented 7 years ago

@larrytech7 Do you use java or kotlin version?

larrytech7 commented 7 years ago

I'm using java.

On Sun, Jan 22, 2017, 8:47 PM Denis Nikiforov notifications@github.com wrote:

@larrytech7 https://github.com/larrytech7 Are you use java or kotlin version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Popalay/Tutors/issues/1#issuecomment-274354071, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMQfTrQXorkpXo8IRNn56Ygt0-KsTEwks5rU7JigaJpZM4LqFuO .

ReginFell commented 7 years ago

Fix this issue in PR https://github.com/Popalay/Tutors/pull/2

Still not saving state per activity rotation, because it is more about activity logic

larrytech7 commented 7 years ago

@ReginFell would be nice if your pr is approved. Hope is works well enough. Thanks for helping out.

Popalay commented 7 years ago

PR has been approved. Check 1.0.2 version

larrytech7 commented 7 years ago

So what version of the library is now available?

2017-01-23 16:14 GMT+01:00 Denis Nikiforov notifications@github.com:

PR has been approved

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Popalay/Tutors/issues/1#issuecomment-274514247, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMQfRkagj66JWp-CE1iYmrsEkWkdl-bks5rVMPjgaJpZM4LqFuO .

-- Akah Larry N.H

Android Engineer Founder @IceTeck Co-Founder @Traveler www.iceteck.com www.traveler.cm

Developing technologies for emergence and sustainable development.

Popalay commented 7 years ago

@larrytech7 v1.0.2

larrytech7 commented 7 years ago

Great, i'll get it ASAP. Thanks for all the effort. There's another suggestion i wanted to talk about. It's about the position of the 'continue' button. It's default position causes it to hide the Floating Action Button. If the position could be changed, it could be even more awesome. You guys are amazing.

Cheers

2017-01-23 16:22 GMT+01:00 Denis Nikiforov notifications@github.com:

@larrytech7 https://github.com/larrytech7 v1.0.2

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Popalay/Tutors/issues/1#issuecomment-274516441, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMQfY-2Awdjqadt5d0khFaMKTItQTdRks5rVMWbgaJpZM4LqFuO .

-- Akah Larry N.H

Android Engineer Founder @IceTeck Co-Founder @Traveler www.iceteck.com www.traveler.cm

Developing technologies for emergence and sustainable development.

Popalay commented 7 years ago

@larrytech7 I can provide a builder for button gravity (START, END). Could you add suggestion?

larrytech7 commented 7 years ago

That could be an initial approach, but again, the there could be other elements at these points. So we could find a way to let users specify the position as a more flexible location.

2017-01-23 16:30 GMT+01:00 Denis Nikiforov notifications@github.com:

@larrytech7 https://github.com/larrytech7 I can provide a builder for button gravity (START, END)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Popalay/Tutors/issues/1#issuecomment-274519084, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMQfeW-FEK_H4M4K5UQCgUfm6JjqWCdks5rVMezgaJpZM4LqFuO .

-- Akah Larry N.H

Android Engineer Founder @IceTeck Co-Founder @Traveler www.iceteck.com www.traveler.cm

Developing technologies for emergence and sustainable development.

larrytech7 commented 7 years ago

What if the button came immediately just after the Text, maybe as a widget at the bottom of the tutorial text?

Popalay commented 7 years ago

@larrytech7 I'll investigate this problem.

larrytech7 commented 7 years ago

Awesome.

On Mon, Jan 23, 2017, 4:39 PM Denis Nikiforov notifications@github.com wrote:

@larrytech7 https://github.com/larrytech7 I'll investigate this problem.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Popalay/Tutors/issues/1#issuecomment-274521635, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMQfWZ1uSACuMzoDanHPEc-JB-M9Rgkks5rVMmvgaJpZM4LqFuO .

ReginFell commented 7 years ago

@Popalay Maybe we can put something like viewgroup into builder to support custom views?