Popax21 / synaTudor

GNU Lesser General Public License v2.1
92 stars 10 forks source link

synaTudor failes to compile on Fedora 39 #23

Open aboutdavid opened 10 months ago

aboutdavid commented 10 months ago

I'm not really good at bug reporting, sorry. I've managed to get meson build and ninja to work, but installing it seems to fail.

[1/6] Compiling C object libfprint-tod/libtudor_tod.so.p/src_device.c.o
FAILED: libfprint-tod/libtudor_tod.so.p/src_device.c.o 
ccache cc -Ilibfprint-tod/libtudor_tod.so.p -Ilibfprint-tod -I../libfprint-tod -I../libtudor/inc -I../tudor-host/inc -I../tudor-host-launcher/inc -I/usr/include/nss3 -I/usr/include/libusb-1.0 -I/usr/include/json-glib-1.0 -I/usr/include/nspr4 -I/usr/local/include/libfprint-2/tod-1 -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount -I/usr/local/include/libfprint-2 -I/usr/include/blkid -I/usr/include/gusb-1 -I/usr/include/pixman-1 -I/usr/include/sysprof-6 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O0 -g -fPIC -pthread -D_GNU_SOURCE -Wno-missing-braces -MD -MQ libfprint-tod/libtudor_tod.so.p/src_device.c.o -MF libfprint-tod/libtudor_tod.so.p/src_device.c.o.d -o libfprint-tod/libtudor_tod.so.p/src_device.c.o -c ../libfprint-tod/src/device.c
../libfprint-tod/src/device.c: In function ‘fpi_device_tudor_class_init’:
../libfprint-tod/src/device.c:176:14: error: ‘FpDeviceClass’ {aka ‘struct _FpDeviceClass’} has no member named ‘clear_storage’
  176 |     dev_class->clear_storage = fpi_device_clear_storage;
      |              ^~
../libfprint-tod/src/device.c:178:5: warning: implicit declaration of function ‘fpi_device_class_auto_initialize_features’ [-Wimplicit-function-declaration]
  178 |     fpi_device_class_auto_initialize_features(dev_class);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[2/6] Compiling C object libfprint-tod/libtudor_tod.so.p/src_verify.c.o
FAILED: libfprint-tod/libtudor_tod.so.p/src_verify.c.o 
ccache cc -Ilibfprint-tod/libtudor_tod.so.p -Ilibfprint-tod -I../libfprint-tod -I../libtudor/inc -I../tudor-host/inc -I../tudor-host-launcher/inc -I/usr/include/nss3 -I/usr/include/libusb-1.0 -I/usr/include/json-glib-1.0 -I/usr/include/nspr4 -I/usr/local/include/libfprint-2/tod-1 -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount -I/usr/local/include/libfprint-2 -I/usr/include/blkid -I/usr/include/gusb-1 -I/usr/include/pixman-1 -I/usr/include/sysprof-6 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O0 -g -fPIC -pthread -D_GNU_SOURCE -Wno-missing-braces -MD -MQ libfprint-tod/libtudor_tod.so.p/src_verify.c.o -MF libfprint-tod/libtudor_tod.so.p/src_verify.c.o.d -o libfprint-tod/libtudor_tod.so.p/src_verify.c.o -c ../libfprint-tod/src/verify.c
../libfprint-tod/src/verify.c: In function ‘verify_acked_cb’:
../libfprint-tod/src/verify.c:87:5: warning: implicit declaration of function ‘fpi_device_report_finger_status_changes’ [-Wimplicit-function-declaration]
   87 |     fpi_device_report_finger_status_changes(FP_DEVICE(tdev), FP_FINGER_STATUS_NEEDED, FP_FINGER_STATUS_NONE);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../libfprint-tod/src/verify.c:87:62: error: ‘FP_FINGER_STATUS_NEEDED’ undeclared (first use in this function)
   87 |     fpi_device_report_finger_status_changes(FP_DEVICE(tdev), FP_FINGER_STATUS_NEEDED, FP_FINGER_STATUS_NONE);
      |                                                              ^~~~~~~~~~~~~~~~~~~~~~~
../libfprint-tod/src/verify.c:87:62: note: each undeclared identifier is reported only once for each function it appears in
../libfprint-tod/src/verify.c:87:87: error: ‘FP_FINGER_STATUS_NONE’ undeclared (first use in this function)
   87 |     fpi_device_report_finger_status_changes(FP_DEVICE(tdev), FP_FINGER_STATUS_NEEDED, FP_FINGER_STATUS_NONE);
      |                                                                                       ^~~~~~~~~~~~~~~~~~~~~
[3/6] Compiling C object libfprint-tod/libtudor_tod.so.p/src_enroll.c.o
FAILED: libfprint-tod/libtudor_tod.so.p/src_enroll.c.o 
ccache cc -Ilibfprint-tod/libtudor_tod.so.p -Ilibfprint-tod -I../libfprint-tod -I../libtudor/inc -I../tudor-host/inc -I../tudor-host-launcher/inc -I/usr/include/nss3 -I/usr/include/libusb-1.0 -I/usr/include/json-glib-1.0 -I/usr/include/nspr4 -I/usr/local/include/libfprint-2/tod-1 -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount -I/usr/local/include/libfprint-2 -I/usr/include/blkid -I/usr/include/gusb-1 -I/usr/include/pixman-1 -I/usr/include/sysprof-6 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O0 -g -fPIC -pthread -D_GNU_SOURCE -Wno-missing-braces -MD -MQ libfprint-tod/libtudor_tod.so.p/src_enroll.c.o -MF libfprint-tod/libtudor_tod.so.p/src_enroll.c.o.d -o libfprint-tod/libtudor_tod.so.p/src_enroll.c.o -c ../libfprint-tod/src/enroll.c
../libfprint-tod/src/enroll.c: In function ‘enroll_start_acked_cb’:
../libfprint-tod/src/enroll.c:125:5: warning: implicit declaration of function ‘fpi_device_report_finger_status_changes’ [-Wimplicit-function-declaration]
  125 |     fpi_device_report_finger_status_changes(FP_DEVICE(tdev), FP_FINGER_STATUS_NEEDED, FP_FINGER_STATUS_NONE);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../libfprint-tod/src/enroll.c:125:62: error: ‘FP_FINGER_STATUS_NEEDED’ undeclared (first use in this function)
  125 |     fpi_device_report_finger_status_changes(FP_DEVICE(tdev), FP_FINGER_STATUS_NEEDED, FP_FINGER_STATUS_NONE);
      |                                                              ^~~~~~~~~~~~~~~~~~~~~~~
../libfprint-tod/src/enroll.c:125:62: note: each undeclared identifier is reported only once for each function it appears in
../libfprint-tod/src/enroll.c:125:87: error: ‘FP_FINGER_STATUS_NONE’ undeclared (first use in this function)
  125 |     fpi_device_report_finger_status_changes(FP_DEVICE(tdev), FP_FINGER_STATUS_NEEDED, FP_FINGER_STATUS_NONE);
      |                                                                                       ^~~~~~~~~~~~~~~~~~~~~
[4/6] Compiling C object libfprint-tod/libtudor_tod.so.p/src_identify.c.o
FAILED: libfprint-tod/libtudor_tod.so.p/src_identify.c.o 
ccache cc -Ilibfprint-tod/libtudor_tod.so.p -Ilibfprint-tod -I../libfprint-tod -I../libtudor/inc -I../tudor-host/inc -I../tudor-host-launcher/inc -I/usr/include/nss3 -I/usr/include/libusb-1.0 -I/usr/include/json-glib-1.0 -I/usr/include/nspr4 -I/usr/local/include/libfprint-2/tod-1 -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount -I/usr/local/include/libfprint-2 -I/usr/include/blkid -I/usr/include/gusb-1 -I/usr/include/pixman-1 -I/usr/include/sysprof-6 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O0 -g -fPIC -pthread -D_GNU_SOURCE -Wno-missing-braces -MD -MQ libfprint-tod/libtudor_tod.so.p/src_identify.c.o -MF libfprint-tod/libtudor_tod.so.p/src_identify.c.o.d -o libfprint-tod/libtudor_tod.so.p/src_identify.c.o -c ../libfprint-tod/src/identify.c
../libfprint-tod/src/identify.c: In function ‘identify_acked_cb’:
../libfprint-tod/src/identify.c:131:5: warning: implicit declaration of function ‘fpi_device_report_finger_status_changes’ [-Wimplicit-function-declaration]
  131 |     fpi_device_report_finger_status_changes(FP_DEVICE(tdev), FP_FINGER_STATUS_NEEDED, FP_FINGER_STATUS_NONE);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../libfprint-tod/src/identify.c:131:62: error: ‘FP_FINGER_STATUS_NEEDED’ undeclared (first use in this function)
  131 |     fpi_device_report_finger_status_changes(FP_DEVICE(tdev), FP_FINGER_STATUS_NEEDED, FP_FINGER_STATUS_NONE);
      |                                                              ^~~~~~~~~~~~~~~~~~~~~~~
../libfprint-tod/src/identify.c:131:62: note: each undeclared identifier is reported only once for each function it appears in
../libfprint-tod/src/identify.c:131:87: error: ‘FP_FINGER_STATUS_NONE’ undeclared (first use in this function)
  131 |     fpi_device_report_finger_status_changes(FP_DEVICE(tdev), FP_FINGER_STATUS_NEEDED, FP_FINGER_STATUS_NONE);
      |                                                                                       ^~~~~~~~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.

I couldn't find a packaged version of fprint-tod that would work so I took it from packages.ubuntu.com and compiled it successfully. Should I get another version, or should I try something else?

Popax21 commented 10 months ago

It seems like the libfprint-tod version you got is rather old and misses some stuff the tod module depends on. I would recommend trying to just install it from source instead of using the Ubuntu package (I can link the upstream repo later if you have issues locating it).

aboutdavid commented 10 months ago

Ah sorry. I don't deal with building things often lol. Is this the upstream repo? https://gitlab.freedesktop.org/3v1n0/libfprint/-/tree/tod

aboutdavid commented 10 months ago

Okay thank you. I also face one last issue. I installed fprintd to get the fprintd-enroll command, but it keeps saying nodevicesfound. Both services that are supposed to be running are running without failure it seems, however.

[david@laptop ~]$ fprintd-enroll -f right-index-finger
Impossible to enroll: GDBus.Error:net.reactivated.Fprint.Error.NoSuchDevice: No devices available
[david@laptop ~]$ systemctl status fprintd
● fprintd.service - Fingerprint Authentication Daemon
     Loaded: loaded (/usr/lib/systemd/system/fprintd.service; static)
    Drop-In: /usr/lib/systemd/system/service.d
             └─10-timeout-abort.conf
     Active: active (running) since Mon 2023-12-04 20:12:39 EST; 3s ago
       Docs: man:fprintd(1)
   Main PID: 7794 (fprintd)
      Tasks: 6 (limit: 14040)
     Memory: 1.4M
        CPU: 93ms
     CGroup: /system.slice/fprintd.service
             └─7794 /usr/libexec/fprintd

Dec 04 20:12:39 laptop systemd[1]: Starting fprintd.service - Fingerprint Authentication Daemon...
Dec 04 20:12:39 laptop systemd[1]: Started fprintd.service - Fingerprint Authentication Daemon.
[david@laptop ~]$  sudo systemctl status tudor-host-launcher
● tudor-host-launcher.service - Tudor host launcher DBus service
     Loaded: loaded (/usr/lib/systemd/system/tudor-host-launcher.service; static)
    Drop-In: /usr/lib/systemd/system/service.d
             └─10-timeout-abort.conf
     Active: active (running) since Mon 2023-12-04 20:09:54 EST; 1min 38s ago
   Main PID: 7409 (tudor_host_laun)
      Tasks: 4 (limit: 14040)
     Memory: 876.0K
        CPU: 60ms
     CGroup: /system.slice/tudor-host-launcher.service
             └─7409 /sbin/tudor/tudor_host_launcher

Dec 04 20:09:54 laptop systemd[1]: Starting tudor-host-launcher.service - Tudor host launcher DBus service...
Dec 04 20:09:54 laptop systemd[1]: Started tudor-host-launcher.service - Tudor host launcher DBus service.

Setting SELinux to permissive does not work (even after starting both processes once more)

Popax21 commented 10 months ago

You'll need to link fprintd against libfprint-tod, not just install it from the package manager.

aboutdavid commented 10 months ago

Sorry, how would linking it work? I'm unsure. I tried looking, but I can't seem to find a way.

Popax21 commented 10 months ago

Assuming you have built and installed libfprint-tod from source, you would have to do the same thing for fprintd.