search

PopcornFX / O3DEPopcornFXPlugin

PopcornFX plugin for O3DE
https://www.popcornfx.com/
Other
13 stars 12 forks source link

Fix monolithic builds and other errors #37

Closed mbalfour-amzn closed 1 year ago

mbalfour-amzn commented 1 year ago

This fixes 3 separate problems: 1) The asset ID recently moved to a header file had a cut-and-paste error causing it to have the same ID as the EditorEmitterComponentTypeId. It has been restored to the correct ID. 2) The PopcornFXFeatureProcessor class was missing an allocator declaration, causing an assert at startup due to a size mismatch. 3) The PopcornFXRendererLoader didn't work correctly with monolithic builds that don't use the Asset Processor. It still tried to compile assets, which caused warnings for images but still worked, but failed for geometry because the asset would not get loaded if it couldn't compile. This corrects the geometry failure and also removes the compile asset failure warnings in the cases that the Asset Processor isn't connected.

mbalfour-amzn commented 1 year ago

@ValPKFX Please review at your earliest convenience!

ValPKFX commented 1 year ago

Sorry for that copy paste error 😅 Thank you for all these fixes!