search

PopcornFX / O3DEPopcornFXPlugin

PopcornFX plugin for O3DE
https://www.popcornfx.com/
Other
13 stars 12 forks source link

Billboarding issued for main view only, ignores shadow cascades and submits PopcornFX draw calls for all views #53

Closed HugoPKFX closed 1 year ago

HugoPKFX commented 1 year ago

This is invalid. Billboarding should be done for all views (have 0 impact for GPU billboarding / instanced draws, but it does produce visible artefacts for CPU billboarded geom, i.e. ribbons) Should be refactored so this is implemented correctly, the render code also submits PKFX draw calls for all views which is wrong. Only draw calls with CastShadows enabled should submit to shadow passes.

HugoPKFX commented 1 year ago

Draw calls that have CastShadows set to false do not contribute anymore to shadow cascades (PopcornFX 2.15.9/2.16.4).

This is still the case however (not fixed):

Billboarding should be done for all views (have 0 impact for GPU billboarding / instanced draws, but it does produce visible artefacts for CPU billboarded geom, i.e. ribbons)
Should be refactored so this is implemented correctly, the render code also submits PKFX draw calls for all views which is wrong.
HugoPKFX commented 1 year ago

Marking resolved, re-open issue if needed for remaining bug.