search

PopcornFX / O3DEPopcornFXPlugin

PopcornFX plugin for O3DE
https://www.popcornfx.com/
Other
13 stars 12 forks source link

Linux monolithic build fixes #59

Closed SelfishOlex closed 1 year ago

SelfishOlex commented 1 year ago

These fixes are required to fix compilation and linking issues on Linux when building monolitihic game launcher.

For example:

cmake -S /home/olex/git/o3de -B /home/olex/git/o3de/build/mono -G "Ninja Multi-Config" \
    -DALLOW_SETTINGS_REGISTRY_DEVELOPMENT_OVERRIDES=0 \
    -DLY_MONOLITHIC_GAME=1 \
    -DLY_PROJECTS="/home/olex/git/o3de-multiplayersample" 

cmake --build /home/olex/git/o3de/build/mono \
    --target MultiplayerSample.ServerLauncher MultiplayerSample.GameLauncher --config profile

I also had to install binutils-dev packaged on Ubuntu:

sudo apt-get install binutils-dev

Fixes https://github.com/PopcornFX/O3DEPopcornFXPlugin/issues/55

ValPKFX commented 1 year ago

Thank you for this fix. I'm just thinking it should be possible and probably better to put it directly in the PopcornFX package since it's a dependency of the runtime libraries. I should be able to add it in FindPopcornFX.cmake located in o3de-packages\packages\PopcornFX-2.16.5-O3DE-linux. I'm currently re setting up a linux to try this. Do you need this PR quickly? Also, bfd is required only for debug and profile configuration, I will try at the same time to link it only for those configurations.

SelfishOlex commented 1 year ago

Thank you for this fix. I'm just thinking it should be possible and probably better to put it directly in the PopcornFX package since it's a dependency of the runtime libraries. I should be able to add it in FindPopcornFX.cmake located in o3de-packages\packages\PopcornFX-2.16.5-O3DE-linux. I'm currently re setting up a linux to try this. Do you need this PR quickly? Also, bfd is required only for debug and profile configuration, I will try at the same time to link it only for those configurations.

A proper fix would be ideal! @ValPKFX

ValPKFX commented 1 year ago

I've pushed the fix on the development branch and explained here: https://github.com/PopcornFX/O3DEPopcornFXPlugin/issues/55#issuecomment-1613399080 I will close this PR, but do not hesitate to tell me if you still have issues or if the fix seems wrong to you. Thank you again!