search

PopcornFX / O3DEPopcornFXPlugin

PopcornFX plugin for O3DE
https://www.popcornfx.com/
Other
13 stars 12 forks source link

giving value in GetValueColor a default color to fix warning as error msg #61

Closed tkothadev closed 1 year ago

tkothadev commented 1 year ago

When trying to compile o3de-multiplayersample-assets with O3DEPopcornFXPlugin via CMake, I get the following issues:

[INFO] root: C:\workspace\dev\o3de-multiplayersample-assets\Gems\O3DEPopcornFXPlugin\Code\Source\Components\Attributes\TrackView\PopcornFXTrackViewAttribute.cpp(327): error C2220: the following warning is treated as an error [C:\workspace\dev\o3de-multiplayersample\build\windows\External\O3DEPopcornFXPlugin-bbe9e60f\Code\PopcornFX.Static.vcxproj]

[INFO] root: C:\workspace\dev\o3de-multiplayersample-assets\Gems\O3DEPopcornFXPlugin\Code\Source\Components\Attributes\TrackView\PopcornFXTrackViewAttribute.cpp(327): warning C4700: uninitialized local variable 'value' used [C:\workspace\dev\o3de-multiplayersample\build\windows\External\O3DEPopcornFXPlugin-bbe9e60f\Code\PopcornFX.Static.vcxproj]

The proposed fix simply initializes the value to AZ::Colors:HotPink. Afterwards, everything compiles normally.

ValPKFX commented 1 year ago

Thank you!