PopcornFX / O3DEPopcornFXPlugin

PopcornFX plugin for O3DE
https://www.popcornfx.com/
Other
13 stars 12 forks source link

Is it compatible with O3DE 2305.x release build? #69

Closed ohmaya closed 1 year ago

ohmaya commented 1 year ago

O3DE already has 2 "2305" releases.

However, 2305 is not listed for v2.17.4 or v2.17.3:

And, what is 23.03? Not listed here: https://github.com/o3de/o3de/releases.

v2.17.4 says "Fixed #12799: O3DE: Gem fails compilation in release configuration on Linux", it seems also fixing for me on Windows. But I still need to dismiss LogBakerMessages to build. When launching:

Thanks.

ValPKFX commented 1 year ago

The gem is compatible with both versions of 2305. The 23.03 was a typo, thank you for reporting it. I've updated the readme and kept only 23.05 since we will focus on this version and the next 23.10.

There was indeed issues in release for both linux and windows but they should be fixed now.

Is it crashing in the PopcornFX gem? It seems the commit d63c217 is on the development branch and not the main 2305.1, maybe there is new issues. I will retry with this commit and keep you informed.

ohmaya commented 1 year ago

The only issue: To build for release, I need to dismiss "LogBakerMessages":

#if (PK_MESSAGE_STREAM_NO_MESSAGES == 0)
    LogBakerMessages(bakerMessages);
#endif

#if (PK_MESSAGE_STREAM_NO_MESSAGES == 0)
void    CBakerManager::LogBakerMessages(const CMessageStream &messages)
{
}
#endif
ValPKFX commented 1 year ago

Oh it was in the Builders target. I only tried to build the GameLauncher in release, not the Editor. Didn't know it was still compiling it even with the if(PAL_TRAIT_BUILD_HOST_TOOLS) in the CMakeLists.txt. Especially since in release there is no asset processor so it shouldn't use this target. Anyway, I've added your fix on the development branch and it will be released in next patches. Thank you!