search

PopcornFX / O3DEPopcornFXPlugin

PopcornFX plugin for O3DE
https://www.popcornfx.com/
Other
13 stars 12 forks source link

Compile Error with O3DE Dev Latest: GeometryView Class API Changed #80

Closed AMZN-Gene closed 2 months ago

AMZN-Gene commented 2 months ago

Popcorn Fx dev branch no longer compiles on O3D dev branch due to DrawIndexed API Changes

Steps to Repro

  1. Pull latest O3DE development branch
  2. Build PopcornFx.Editor module

Expected Results Compile without error

Actual Results Compiler errors

1>D:\prj\gems\o3de-multiplayersample-assets\Gems\O3DEPopcornFXPlugin\Code\Source\Integration\Render\AtomIntegration\BillboardBatchDrawer.cpp(527,19): error C2039: 'm_instanceCount': is not a member of 'AZ::RHI::DrawIndexed'
1>  dc.m_DrawIndexed.m_instanceCount = toEmit.m_TotalParticleCount; // Sliced draw calls can draw < drawPass.m_TotalParticleCount
1>                   ^ (compiling source file 'CMakeFiles/PopcornFX.Static.dir/Unity/unity_0_cxx.cxx')
1>    D:\prj\o3de\Gems\Atom\RHI\Code\Include\Atom\RHI\DeviceDrawArguments.h(45,12):
1>    see declaration of 'AZ::RHI::DrawIndexed'
1>        struct DrawIndexed
1>               ^
1>D:\prj\gems\o3de-multiplayersample-assets\Gems\O3DEPopcornFXPlugin\Code\Source\Integration\Render\AtomIntegration\BillboardBatchDrawer.cpp(528,19): error C2039: 'm_instanceOffset': is not a member of 'AZ::RHI::DrawIndexed'
1>  dc.m_DrawIndexed.m_instanceOffset = 0;
1>                   ^ (compiling source file 'CMakeFiles/PopcornFX.Static.dir/Unity/unity_0_cxx.cxx')
1>    D:\prj\o3de\Gems\Atom\RHI\Code\Include\Atom\RHI\DeviceDrawArguments.h(45,12):
1>    see declaration of 'AZ::RHI::DrawIndexed'
1>        struct DrawIndexed
1>               ^
1>D:\prj\gems\o3de-multiplayersample-assets\Gems\O3DEPopcornFXPlugin\Code\Source\Integration\Render\AtomIntegration\RibbonBatchDrawer.cpp(416,19): error C2039: 'm_instanceCount': is not a member of 'AZ::RHI::DrawIndexed'
1>  dc.m_DrawIndexed.m_instanceCount = 1;
1>                   ^ (compiling source file 'CMakeFiles/PopcornFX.Static.dir/Unity/unity_0_cxx.cxx')
1>    D:\prj\o3de\Gems\Atom\RHI\Code\Include\Atom\RHI\DeviceDrawArguments.h(45,12):
1>    see declaration of 'AZ::RHI::DrawIndexed'
1>        struct DrawIndexed
1>               ^

Atom PR from today changed the API

ValPKFX commented 2 months ago

Thank you for the notice. This is fixed on the development branch.