search

PopcornTimeCommunity / desktop

official desktop repository of original popcorn time lighweight
https://popcorntime.is
Other
267 stars 75 forks source link

nwjs binary updated to latest to fix segment fault on macOS Sierra #107

Closed haroondilshad closed 7 years ago

haroondilshad commented 7 years ago

This PR will resolve #105 and #106 . I investigated the issue and it was most probably a segfault and the latest version of nwjs fixes that. I reached at that conclusion because exited with code 11 usually refers to a segment fault so I went ahead and tested with Node Segment fault handler and that indeed was the issue. It'll be very hard to actually try to track the issue down and fix while staying with this very outdated version of nwjs and in my opinion, future is the way to go.

haroondilshad commented 7 years ago

@YIFYtorrents please merge

haroondilshad commented 7 years ago

With newer versions of nw-builder this is reported [Error: Unsupported NW.js version '0.12.3 (sdk)' for platform 'osx64'] There's not much support for 0.12.3 anymore and we should move on for the better

YIFYtorrents commented 7 years ago

There's not much support for 0.12.3 anymore and we should move on for the better

That is a good idea, by the way I just saw this PR the first time. I am going to merge it as soon as I have tested it.

captainyarr commented 7 years ago

My test haven't been positive with this PR running in Linux, but could be just me. Let me know if you have better results.

haroondilshad commented 7 years ago

@captainyarr If you can test further and make a comprehensive list of issues I'd be willing to fix them in a few days' time. @YIFYtorrents I didn't test it comprehensively and just tested on Sierra, if your tests reveal something broken I'd be more than happy to fix