search

PopcornTimeCommunity / desktop

official desktop repository of original popcorn time lighweight
https://popcorntime.is
Other
267 stars 75 forks source link

Fixing the JS error causing "stream:start" event to not be bound #117

Closed homeslicesolutions-zz closed 7 years ago

homeslicesolutions-zz commented 7 years ago

After some debugging, the "stream:start" event that launches the player was not bound to the App.vent namespace. It was due to a JS error caused by a library "unzip-response" which contained ES6 arrow functions not supported by the current requirement of NWJS 0.12.3. The "unzip-response" module was used by "simple-get" which is used by a chain of other modules. To mitigate this issue, I decided to tighten the versions to make sure what is being required is ES5 friendly hence fixing the JS error and allowing the "stream:start" event to be bound. Phew... anyway, it's a small change and it works fine.

homeslicesolutions-zz commented 7 years ago

Use #107 as fix for this issue