Closed seanstern closed 3 years ago
pose-core@2.1.1 has the following dependency list
"dependencies": { "@types/invariant": "^2.2.29", "@types/node": "^10.0.5", "hey-listen": "^1.0.5", "rollup-plugin-typescript2": "^0.25.2", "tslib": "^1.10.0", "typescript": "^3.7.2" },
Note that typescript is included as a dependency.
typescript
This is a problem for any project that
pose-core
dependency
"devDependencies"
"dependncies"
Essentially, these projects pull in an additional 50Mb of unnecessary data because pose-core is pulling in typescript as a dependency.
I believe pose-core should specify typescript as a devDependency only.
devDependency
Steps to reproduce the behavior:
{ "dependencies": "pose-core": "@2.1.1" }
yarn install --production
node_modules/typescrpt
typescript should not be installed
typescript was added as a dependency to packages/pose-core/package.json in this commit
packages/pose-core/package.json
It was not removed until this commit
However, the latter commit has not been published to npm or yarn because both still list typescript as a dependency
This seems to be fixed, but not yet published, please publish a new version
Bug Description
pose-core@2.1.1 has the following dependency list
Note that
typescript
is included as a dependency.This is a problem for any project that
pose-core
as adependency
"devDependencies"
in production environments (leaving only"dependncies"
) to reduce overall project size in production environmentsEssentially, these projects pull in an additional 50Mb of unnecessary data because
pose-core
is pulling intypescript
as a dependency.I believe
pose-core
should specifytypescript
as adevDependency
only.How to reproduce
Steps to reproduce the behavior:
{ "dependencies": "pose-core": "@2.1.1" }
yarn install --production
node_modules/typescrpt
to see thattypescript
has been installedExpected behaviour
typescript
should not be installedAdditional context
typescript
was added as adependency
topackages/pose-core/package.json
in this commitIt was not removed until this commit
However, the latter commit has not been published to npm or yarn because both still list
typescript
as adependency