Popmotion / popmotion

Simple animation libraries for delightful user interfaces
https://popmotion.io
20k stars 663 forks source link

Indicate that package has no sideEffects #879

Closed voxpelli closed 3 years ago

voxpelli commented 4 years ago

To help tree shaking in Webpack as Webpack for compatibility reasons otherwise will assume that we package will have sideEffects.

See: https://github.com/stereobooster/package.json#sideeffects And: https://webpack.js.org/guides/tree-shaking/

stokesman commented 4 years ago

It does have side effects. Tree-shaking can still happen since pure functions are annotated. I think Webpack just needs to be in production mode.