PopulateTools / decidim-module-extra_user_fields

Add dynamic custom fields to users
https://decidim.org
GNU Affero General Public License v3.0
3 stars 13 forks source link

Add tests to 0.27 #17

Closed paulinebessoles closed 1 year ago

paulinebessoles commented 1 year ago

This pull request aims to:

paulinebessoles commented 1 year ago

@ferblape could you please approve the workflow to run so I can check nothing fails in the ci? 😁

furilo commented 1 year ago

Done!

paulinebessoles commented 1 year ago

@furilo sorry, could you run it again? 😊

furilo commented 1 year ago

https://github.com/PopulateTools/decidim-module-extra_user_fields/actions/runs/6025862629/job/16347687383?pr=17 ? ;)

armandfardeau commented 1 year ago

PopulateTools/decidim-module-extra_user_fields/actions/runs/6025862629/job/16347687383?pr=17 ? ;)

Error: The operation was canceled. :)

paulinebessoles commented 1 year ago

@furilo I really hope it's the last time! 🤞

furilo commented 1 year ago

Haha, don't worry. Dealing with tests, it probably won't ;)

furilo commented 1 year ago

The PR is looking great! Thanks a lot. Would it make sense to complete the readme? Our version was quite basic...

paulinebessoles commented 1 year ago

@furilo I added some extra indications in the README, please tell me if you want some more infos!

Furthermore, I started testing one last time in local and saw that some fields are not displayed event though they should be so please do not merge this PR (or convert to draft) for now 😔

paulinebessoles commented 1 year ago

@furilo @ferblape Now the PR is finalized!

Please tell me if you have any change request 😁

ferblape commented 1 year ago

Hi @paulinebessoles thanks for the PR it's fantastic and I'm going to merge it right now.

After that we are going to: