Closed paulinebessoles closed 1 year ago
@ferblape could you please approve the workflow to run so I can check nothing fails in the ci? 😁
Done!
@furilo sorry, could you run it again? 😊
PopulateTools/decidim-module-extra_user_fields/actions/runs/6025862629/job/16347687383?pr=17 ? ;)
Error: The operation was canceled. :)
@furilo I really hope it's the last time! 🤞
Haha, don't worry. Dealing with tests, it probably won't ;)
The PR is looking great! Thanks a lot. Would it make sense to complete the readme? Our version was quite basic...
@furilo I added some extra indications in the README, please tell me if you want some more infos!
Furthermore, I started testing one last time in local and saw that some fields are not displayed event though they should be so please do not merge this PR (or convert to draft) for now 😔
@furilo @ferblape Now the PR is finalized!
Please tell me if you have any change request 😁
Hi @paulinebessoles thanks for the PR it's fantastic and I'm going to merge it right now.
After that we are going to:
extra-fields-0-27
branch will go to master
This pull request aims to: