PopulateTools / gobierto

Plataforma de gobierno abierto open source
https://gobierto.es
GNU Affero General Public License v3.0
74 stars 32 forks source link

Split plugins code in different engines #2376

Open amiedes opened 5 years ago

amiedes commented 5 years ago

Right now the existing plugins are located in the same Rails engine. After discussing in the office we've decided to split them in one-engine per plugin, reasons are:

These plugins share both JS and Ruby code (for test helpers). In order to share this between them one idea was to create a gem, but it's open to other solutions.

In regard to frontend integration, each plugin implements a Vue component named <plugin_name>.vue. Move the plugins from app/javascript/gobierto_plans/plugins/*.vue to the vendor directory. plan_types_controller uses a relative path to load the plugins, keep that in mind.

furilo commented 5 years ago

This should be done now? Please explain reasons to do this so no more explanation is needed.

ferblape commented 5 years ago

Issue updated to consider also moving the Vue components to the proper folder.