PopupMaker / Popup-Maker

Popup Maker plugin for WordPress
https://wppopupmaker.com/
104 stars 38 forks source link

Add content style compatibility classes for popular themes #705

Open danieliser opened 4 years ago

danieliser commented 4 years ago

Some themes for whatever reason reset styles for things like <ul> elements and then only restyle them with bullets inside a container with a specific class. This means that popups won't show bulleted lists automatically which always generates a support ticket that we did something wrong, when its the other way around.

The fix can be as simple as something like the following for the Enfold Theme


function add_custom_popup_class( $classes ) {
​    $classes[] = 'entry-content-wrapper';
​
​    return $classes;
​}
​
​add_filter( 'pum_popup_content_classes', add_custom_popup_class' );```
danieliser commented 4 years ago

@fpcorso This could be as simple as a new empty setting field in the admin where they can enter their own class we append for compatibility. Maybe even a new tab for compatibility fixes since a good portion of our settings are dedicated to that.

PhoenixIV commented 2 years ago

Sweet suggestion. I was just debugging why there are no bullet points and faulty text styling myself. Did not know before that the pop-ups are opened as an iframe. For my theme I am missing the class entry-content

I love your ability to put this report on such a high level of abstraction @danieliser , including the suggestion to add your own classes.

danieliser commented 2 years ago

To be clear @PhoenixIV popups are loaded as divs in the footer, not in iframes.

PhoenixIV commented 2 years ago

Huh. I see! I was confused because there was some iframe action going on while I was logged into WordPress. Thanks!