search

PorktoberRevolution / ReStocked

Kerbal Space Program Art Revamp
99 stars 44 forks source link

CLS Compat Size1to0ServiceModule Tunnel Variant #959

Open Khitiara opened 3 years ago

Khitiara commented 3 years ago

Describe the bug The Size1to0ServiceModule part's tunnel variant should ideally be passable with ConnectedLivingSpaces installed if possible to implement

List of mods installed:

ChrisAdderley commented 3 years ago

If this is the MH part, it should be the base CLS mod's job to implement, no?

Khitiara commented 3 years ago

It is the MH part but the variant that could be interpreted as passable was added by restock hence the issue being opened here - vanilla MH just has the bare shelf version with no visual docking tunnel so CLS doesnt make it passable

ChrisAdderley commented 3 years ago

Hm, well my next logical question is whether CLS can even support passability with variants? It couldn't last time I wrote a patch for it.

Khitiara commented 3 years ago

It cant with vanilla's PartVariant bit to my knowledge, though should be possible for them to add in the same way that i think its fairings? can change the texture from a partmodule using variants thatd just need support from them. I know it works with B9PartSwitch because I started cobbling together a solution using that for my local save since I already have B9PartSwitch, but that isnt a dependency of Restock and id assume yall dont want to pull in more dependencies for the mod given its aim and scope

ChrisAdderley commented 3 years ago

Well... we can't do this though. If CLS goes and implements the ability to handle variants we can adjust that. I will leave this open for that.