PorktoberRevolution / ReStocked

Kerbal Space Program Art Revamp
101 stars 44 forks source link

Oscar B volume fix #967

Closed jdmj closed 2 years ago

jdmj commented 3 years ago

ReStockPlus/Patches/FuelTanks/restock-oscar-b-volume-fix.cfg The patch doesn't work if there's a fuel switch mod installed. Encountered with InterstellarFuelSwitch but I'm sure it will happen with any mod which uses resource values for its own calculations and loads before Restock. It happens because IFS loads first and generates tank configs from stock values, then Restock loads, then the patch is applied (which doesn't change a thing because IFS configs are already in place). Not sure why there's :AFTER directive at all, :FIRST would be more appropriate for this patch, I think, since it's supposed to fix stock values.

ChrisAdderley commented 3 years ago

I await your tested pull request.

ChrisAdderley commented 3 years ago

Merged for 1.4.3

Poodmund commented 2 years ago

Fixed with https://github.com/PorktoberRevolution/ReStocked/commit/305416c10259f357dc6508bdba90829df87dac5a