PortAudio / portaudio

PortAudio is a cross-platform, open-source C language library for real-time audio input and output.
Other
1.43k stars 296 forks source link

CoreAudio PaStreamCallbackTimeInfo implementation not working in some cases #144

Open PortAudio-admin opened 13 years ago

PortAudio-admin commented 13 years ago

Issue created by @RossBencina

r1537 added a new implementation of PaStreamCallbackTimeInfo

The implementation is incomplete:

  1. inputBufferAdcTime is not computed correctly for all cases (eg full duplex with/without ring buffer).

  2. This patch needs to be reviewed for the case where device and AUHAL sample rates differ (ie SRC is used) and if input and output sample rates differ.

See FIXMES in the patch: http://www.portaudio.com/trac/changeset?reponame=&new=1537%40portaudio/trunk/src/hostapi/coreaudio/pa_mac_core.c&old=1483%40portaudio/trunk/src/hostapi/coreaudio/pa_mac_core.c

PortAudio-admin commented 13 years ago

Comment by @RossBencina

I think it would be a good idea to clean up / refactor the logic in the ioProc, possibly with separate io procs for different input/output duplex. At the moment there is a lot of interleaved and dependent if/else logic that makes things very hard to follow.

PortAudio-admin commented 12 years ago

Comment by @RossBencina

TRAC migration: propagating ticket status from TRAC