PortAudio / portaudio

PortAudio is a cross-platform, open-source C language library for real-time audio input and output.
Other
1.49k stars 307 forks source link

.def file ordinal change for MME symbols during dev cycle. #784

Closed RossBencina closed 2 months ago

RossBencina commented 1 year ago

Since V19.7.0 was released the following changes were made:

MME symbols were introduced here Aug 19 2021:

https://github.com/PortAudio/portaudio/commit/093d7f7fdf2cd1dbed0cb888257b6b39b4bed7db

And then the ordinals were changed here Feb 7 2022:

https://github.com/PortAudio/portaudio/commit/605fc89d5763b3d7bfd4803531a23c359a668b73

I don't think that we should have allowed the second change. Once assigned, ordinals should remain stable.

To avoid issues when adding additional WASAPI symbols in future, I think we should renumber the wmme ordinals to start at 80 or 90 prior to the next release.