alsa: do not link with lasound in the PA_ALSA_DYNAMIC case

PortAudio / portaudio

PortAudio is a cross-platform, open-source C language library for real-time audio input and output.

Other

1.43k stars 296 forks source link

alsa: do not link with lasound in the PA_ALSA_DYNAMIC case #834

Closed jcelerier closed 8 months ago

jcelerier commented 1 year ago

it kinda defeats the point of the option (making binaries that will still run on systems without libasound.so.2)

RossBencina commented 12 months ago

LGTM but I'm not competent to sign off on a CMake change. @Be-ing ?

If anyone with CMake chops could comment that would be a great help.

dmitrykos commented 10 months ago

If anyone with CMake chops could comment that would be a great help.

@RossBencina the change looks correct and can be safely merged. When PA_ALSA_DYNAMIC is ON the libasound should not be linked to the binary and @jcelerier is right about it. In the past in 9c4c92fef6f0ef65682062870c87a29eedd79f9e I added dynamic loading possibility for Linux driver just for this reason.

jcelerier commented 8 months ago

thanks!