Portaudio with Oboe Implementation

PortAudio / portaudio

PortAudio is a cross-platform, open-source C language library for real-time audio input and output.

Other

1.39k stars 291 forks source link

Portaudio with Oboe Implementation #840

Open hopefulGiupplo opened 10 months ago

hopefulGiupplo commented 10 months ago

As I said in this issue, I finally can say that this PaOboe implementation seems to be working. Instruction to how to build PortAudio with Oboe are detailed in src/hostapi/oboe/Readme.md

philburk commented 9 months ago

Great work on this HostApi. The code looks very good. Just a few changes needed.

hopefulGiupplo commented 7 months ago

Hello @philburk, I saw you assigned this issue to yourself. Please let me know if I can help :)

hopefulGiupplo commented 1 month ago

Hello @philburk and PA team, I'm here to ask if I can help with any changes, and to ask if you're planning to include pa_oboe in portaudio's next release :) I rebased this work onto the last additions, I hope the library is still correctly built. Please ping me if there's anything I can do!

philburk commented 1 month ago

Thanks for rebasing this code. We are trying to get the next release out soon. This PR will need a deep review and then after it is merged it will need some soak time for other to try it. So I don't think it will make the next release.

I will try to review in depth soon. The code looks very good so far.

RossBencina commented 1 month ago

Hi @hopefulGiupplo, thanks for your contribution, it's looking good but I agree that Phil needs to do a thorough review since he is the Oboe expert. Some other things that would help:

It's not passing CI at the moment, you will need to keep on top of that
It would help if there were some additional testers for your code, if you think that it's ready (and once CI is passing) you could post to the mailing list and request that other people try it
If anyone else is already using this it would be good to hear their feedback here (both in terms of using the implementation and reviewing the source code).

Once Phil is satisfied I will also do a code review.