Closed illuusio closed 8 months ago
Looks good to me, and I just tested it by pulling into my repo and GitHub CI with the Cmake Ubuntu gcc build seems to build proper libportaudio.a with Pulseaudio backend etc.
One thing I noticed is that some of the install steps does not seem to copy the pulseaudio hostapi specific header file into place, while it does so for JACK and ALSA. Ie. pa_jack.h, pa_linux_alsa.h, pa_unix_oss.h gets installed into /usr/include/ but not pa_linux_pulseaudio.h. I guess that would need some refinement for the make install
step.
As Pulseaudio is not currently build on Github workflow build. PR Adds it at least for CMake build